Skip to content

Outline for .active buttons in Windows High Contrast #12242

Open
sabernhardt wants to merge 2 commits into
WordPress:trunkfrom
sabernhardt:active-buttons-high-contrast-outline
Open

Outline for .active buttons in Windows High Contrast #12242
sabernhardt wants to merge 2 commits into
WordPress:trunkfrom
sabernhardt:active-buttons-high-contrast-outline

Conversation

@sabernhardt

Copy link
Copy Markdown
  • Reverts r62467 to remove pseudo-element.
  • Adds a transparent outline to the .active buttons, with a negative outline offset.
  • Increases the width of the outline for the focus state.

Trac 65153

Use of AI Tools: none


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Hi there! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@sabernhardt sabernhardt left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots

Image alignment options in the Classic Editor image replacement dialog

Left button is selected and has focus:
Alignment: button selected with focus

Left button is selected, but the Center button has focus:
Alignment: button is selected but another has focus

Permalink Settings custom tags

Each screenshot shows the year and month number buttons selected, and two screenshots also have the post name selected.

Post name button is selected and has focus:
Permalink Settings: post name tag selected, with focus

Post name button is selected, but the category button has focus:
Permalink Settings: post name tag selected, but the category button has focus

Post name button is not selected, but it has focus:
Permalink Settings: post name tag is not selected, but it has focus

Publish Options button in the Customizer

Publish Options button is selected and has focus:
Publish Options: selected with focus

Publish Options button is selected, but without the focus state:
Publish Options: selected only

@apermo apermo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-hamano t-hamano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This PR works well and does not affect other button variations or modes other than the default contrast mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants